-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add OC stats example code #568
Open
c24t
wants to merge
6
commits into
googleapis:main
Choose a base branch
from
c24t:oc-metrics-sample
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 13, 2021
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/python-spanner API.
label
Sep 13, 2021
Closed
8 tasks
The example code describes creating OpenCensus measures and views, and registering a stats exporter to export metrics to Cloud Monitoring. Stats definitions are taken from the OpenCensus gRPC Stats specification: https://github.com/census-instrumentation/opencensus-specs/blob/80abe4c67b5322ba6f2254c105d4967f0f46ea99/stats/gRPC.md.
c24t
force-pushed
the
oc-metrics-sample
branch
from
September 13, 2021 22:49
c9da739
to
e26f123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GoogleCloudPlatform/python-docs-samples#6514 🦕,
Moved from GoogleCloudPlatform/python-docs-samples#6515.
The last PR included this note:
But to make this clearer: this code won't emit gRPC stats because gRPC-python itself doesn't support OpenCensus tracing. See https://opencensus.io/guides/grpc/.
The sample also uses measures and views from the OpenCensus gRPC Stats
specification. These ought to be moved somewhere like
opencensus-ext-grpc
.@larkee I put these samples in a separate
samples/opencensus/
dir because the other samples don't require OC, let me know if you want this arranged differently.